From 01060cf16dc80c8a41702d9cdf1a8c158e516a5a Mon Sep 17 00:00:00 2001 From: Kevin Wan Date: Mon, 4 Jan 2021 16:36:27 +0800 Subject: [PATCH] close issue of #337 (#347) --- core/syncx/sharedcalls.go | 2 -- 1 file changed, 2 deletions(-) diff --git a/core/syncx/sharedcalls.go b/core/syncx/sharedcalls.go index 9bab2540..c9b07857 100644 --- a/core/syncx/sharedcalls.go +++ b/core/syncx/sharedcalls.go @@ -70,8 +70,6 @@ func (g *sharedGroup) createCall(key string) (c *call, done bool) { func (g *sharedGroup) makeCall(c *call, key string, fn func() (interface{}, error)) { defer func() { - // delete key first, done later. can't reverse the order, because if reverse, - // another Do call might wg.Wait() without get notified with wg.Done() g.lock.Lock() delete(g.calls, key) g.lock.Unlock()